Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 7z2john.py to 7z2john.pl #128

Merged
merged 1 commit into from
May 29, 2022
Merged

Conversation

mda01
Copy link
Contributor

@mda01 mda01 commented May 29, 2022

Fixing this issue:
#127

@solardiz
Copy link
Member

Thanks! BTW, you could have written "Fixes #127" to have merging this PR automatically close the issue.

How about you fix #123 next?

@solardiz solardiz merged commit 44b38a6 into openwall:master May 29, 2022
@eli-b
Copy link

eli-b commented Nov 27, 2022

Would you consider releasing a minor version that includes this fix?

@solardiz
Copy link
Member

@eli-b Do you perhaps mean new binary builds (something you can readily use) more than a release (a technicality)? For just this fix alone, probably no - there are many more things we need to update, including similar ones (there are more *2john tools by now than Johnny is aware of). However, we do need to start doing binary builds again, which would also encourage people to be improving the source code. Maybe we need automated binary builds for a few systems made in the cloud, maybe like @claudioandre-br set up for the main JtR project. @shinnok @AlekseyCherepanov what do you guys think of this? Any volunteers to set this up?

As to releases, I think producing a JtR 2.0 release based on current bleeding-jumbo is a higher priority, then we should make a Johnny release matching it, and consider merging Johnny into the main JtR tree after 2.0. Then just one automated builds setup will cover all.

@eli-b
Copy link

eli-b commented Nov 27, 2022

I guess I meant both a version release and the binary builds that would go with it. Otherwise, I could have tried to build johnny myself from the head of master.

Automated binary builds sound useful.

@shinnok
Copy link
Member

shinnok commented Nov 28, 2022

Hi, updating Johnny at this point is a task of its own, since everything is at least 5 years old. @eli-b, if possible, I would recommend you not wait for a release anytime soon.

@solardiz I'm a bit out of the loop, is JtR 2.0 imminent? If so, maybe I can read up a little on what's changed in the meantime and consider if it's worth updating Johnny solely or just wait and see what would exactly be needed for inclusion into main/Jumbo.

@solardiz
Copy link
Member

@shinnok I think the current jumbo tree is close to what we could release as JtR 2.0 - just need some documentation updates, and to actually make the release (including builds, testing, announcements, etc.) - however, I am busy with other projects, so no, the release is not imminent. Yet you can reasonably update Johnny now to reflect new *2john tools and new/changed john options. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants