Fix issue #455: Check whether the EDevice received a SessionEstablishment or a SessionData message #456
+7
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the context of reverse engagement, check whether the EReader sent a SessionEstablisment message or a SessionData message. If the EReader sent a SessionEstablishment message, use the public key in the message instead of the initial public key in the ReaderEngagement message. Signed-off-by: Nicklas Warming Jacobsen <[email protected]>
nicklaswj
force-pushed
the
differentiate-between-SessionData-and-SessionEstablishment
branch
from
c9e32f0
to
f925b3e
Compare
|
Sorry for taking a while to look at this. I'm trying to understand what bug you are trying to fix. Is it for the case where the mdoc reader sends EReaderKey of curve X in ReaderEngagement and then the mdoc decides to use another curve Y and sends EDeviceKey in DeviceEngagement of curve Y and then the reader sends |
|
Yes exactly. Sorry if I didn't explain it well enough.
…On Wed, 21 Feb 2024, 22.27 David Zeuthen, ***@***.***> wrote:
Sorry for taking a while to look at this. I'm trying to understand what
bug you are trying to fix. Is it for the case where the mdoc reader sends
EReaderKey of curve X in ReaderEngagement and then the mdoc decides to use
another curve Y and sends EDeviceKey in DeviceEngagement of curve Y and
then the reader sends SessionEstablishment with a new EReaderKey with
curve Y instead of SessionData?
—
Reply to this email directly, view it on GitHub
<#456 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAK7TVFOC4AMXWDPCEXKLKDYUZRDXAVCNFSM6AAAAABCIYYLOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJXHE4DMMJRGI>
.
You are receiving this because you authored the thread.Message ID:
<openwallet-foundation-labs/identity-credential/pull/456/c1957986112@
github.com>
|
|
@davidz25 I have a (another) implementation of a working MDL reader implementation you can test with if that will help you. However I can't share it publicly, so I would need to send the link by email or some other private channel. |
|
This code was rewritten in Kotlin, please reopen if this is still an issue and we'll fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of reverse engagement, check whether the EReader sent a SessionEstablisment message or a SessionData message. If the EReader sent a SessionEstablishment message, use the public key in the message instead of the initial public key in the ReaderEngagement message.
Fixes #455