Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #462: Fix race condition in method sendResponse in com.android.identity.wallet.transfer.Communication #463

Conversation

nicklaswj
Copy link

Fixes #462

This PR changes the method sendResponse in class Communication to only close the underlying mTransport after the deviceResponse has been fully sent.

@nicklaswj nicklaswj force-pushed the fix-sendResponse-race-condition branch from 488360d to 60f9643 Compare February 1, 2024 08:13
Nicklas Warming Jacobsen added 2 commits February 1, 2024 09:20
….transfer.Communication sendResponse

If `closeAfterSending` is true, only close the connection after we know the
`deviceResponse` payload have been sent.

Signed-off-by: Nicklas Warming Jacobsen <[email protected]>
Signed-off-by: Nicklas Warming Jacobsen <[email protected]>
@davidz25
Copy link
Contributor

Closing due to inactivity, please reopen if this is still an issue.

@davidz25 davidz25 closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition in class Communication in package com.adroid.identity.wallet.transfer
2 participants