feat: iat disclosable #18
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
force-pushed
the
iat
branch
3 times, most recently
from
b528c49
to
0d47902
Compare
Signed-off-by: Giuseppe De Marco <[email protected]>
peppelinux
commented
Feb 20, 2024
| _res = testcase['user_claims'][ | ||
| [ | ||
| k for k,v in testcase['user_claims'].items() | ||
| if hasattr(k, "value") and k.value == attr_name |
There was a problem hiding this comment.
here I was lazy, I would have to inspect the type, like isinstance(x, SDObj)
peppelinux
commented
Feb 20, 2024
| if include_default_claims: | ||
| claims = { | ||
| "iss": settings["identifiers"]["issuer"], | ||
| "iat": settings["iat"], | ||
| "exp": settings["exp"], | ||
| "exp": settings.get("exp", exp) |
There was a problem hiding this comment.
there are some claims that if not SD then they must/should be present since are required or recommended (that' include_default_claims).
IAT is one of these, if not present as SDobj it must be included in plain
peppelinux
commented
Feb 20, 2024
| claims = dict() | ||
|
|
||
| if not _iat: | ||
| claims['iat'] = iat |
There was a problem hiding this comment.
this must be refactored
I can remove that if and use claims['iat'] = _iat or iat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
iat