Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anoncreds proof validation issue (once credential has been revoked) #3557

Merged
merged 10 commits into from
Mar 12, 2025

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Mar 6, 2025

WIP - integration test to reproduce error

See issue #3556

To run the test:

AGENT_PORT_OVERRIDE=9030 ./run_bdd -t @T003-RFC0454.4b

The askar scenario passes and the anoncreds scenario fails.

@swcurran
Copy link
Contributor

Is this replace by #3570 ? I think it is the same issue, right?

@ianco
Copy link
Contributor Author

ianco commented Mar 11, 2025

Is this replace by #3570 ? I think it is the same issue, right?

Same issue. This PR contains an integration test that demonstrates the issue.

@ianco
Copy link
Contributor Author

ianco commented Mar 11, 2025

Is this replace by #3570 ? I think it is the same issue, right?

Same issue. This PR contains an integration test that demonstrates the issue.

... and the fix in PR #3570 fixes this integration test

@ianco ianco marked this pull request as ready for review March 11, 2025 22:33
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 We could add the @Release tag so these get tested when a release is created.

Signed-off-by: Ian Costanzo <[email protected]>
@jamshale jamshale merged commit 59aef02 into openwallet-foundation:main Mar 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants