feat: cache template file #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleach
force-pushed
the
feat/cache-templates
branch
from
7dbbeae to
f8b87c2
Compare
al-rosenthal
reviewed
Dec 4, 2024
|
|
||
| if (acceptDevRestrictions) { | ||
| templateData = applyDevRestrictions(templateData) | ||
| } | ||
|
|
||
| const template = templateData.find((template) => template.id === templateId) |
There was a problem hiding this comment.
nit: you could just return this value
jleach
force-pushed
the
feat/cache-templates
branch
from
963ac63 to
d3d2c85
Compare
al-rosenthal
approved these changes
Dec 9, 2024
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
jleach
force-pushed
the
feat/cache-templates
branch
from
d3d2c85 to
949f6e5
Compare
|
al-rosenthal
approved these changes
Dec 10, 2024
bryce-mcmath
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Cache the bundle template file for faster access and reliability.
Screenshots, videos, or gifs
n/a
Breaking change guide
n/a
Related Issues
n/a
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓