fix(anoncreds): combine creds into one proof #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
berendsliedrecht
approved these changes
Jun 7, 2024
| const existingCredentialIndex = credentials.findIndex( | ||
| (credential) => | ||
| credential.credentialId === attribute.credentialId && | ||
| attribute.timestamp === credential.credentialEntry.timestamp |
There was a problem hiding this comment.
Won't the credentialId suffice? Why is the timestamp included?
There was a problem hiding this comment.
I wasn't 100 sure, but as we create the revocation state based on the timestamp, it would be possible to have different requirements.
E.g. age > 15 nonRevoked between 100 and 1000 (timestamp)
and name = Berend. nonRevoked between 10.000 and 100.000 (timestamp)..
These would create different revocation states, and therefore I decided to also include timestamp. It's very very rare to have different timestamps, but this at least makes sure the presentation is valid
There was a problem hiding this comment.
Ah okay, makes sense! good catch!
Signed-off-by: Timo Glastra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines attributes and predicates from the same credential into one proof. This way the verifier can assert that e.g. a predicate of age > 15 and attribute of name are from the same cred.
Based on discussion in hyperledger/anoncreds-rs#292
Would be great if there's a bit more control of it in the proof request syntax, as you now have to parse the presentation/proof structure to know whether multiple attributes/predicates come from the same credential (which I suspect no-one does, so request a predicate and attribute at the same time is actually not very secure it seems as you don't know whether they are from the same cred).