feat: OpenIdFed for the verifier #2093
Check failed
There is one commit incorrectly signed off, the check did not pass.
Summary
Sha | Message | Pass or fail reason | |
---|---|---|---|
🟢 | b723485 | feat: working version | Valid sign-off found |
🟢 | bcaed4d | feat: Littlebit of a cleanup for the verifier | Valid sign-off found |
🟢 | 1743fb1 | fix: typescript error | Valid sign-off found |
🟢 | dcd810d | feat: Processed feedback and used the right keys f... | Valid sign-off found |
🟢 | cb6d70f | feat: Added more logging and added unhappy tests | Valid sign-off found |
🟢 | b06c546 | chore: Made some things more logic | Valid sign-off found |
🟢 | 2b8bde5 | feat: Holder side api for getting more context inf... | Valid sign-off found |
🟢 | 8bb4564 | Merge branch 'main' into feature/openid-federation... | Skipped: sign-off not required in merge commit |
🟢 | f6f766d | fix: Merge conflict and changes | Valid sign-off found |
🟢 | b2b3890 | feat: Added fetchEntityConfiguration | Valid sign-off found |
🟢 | 4515ad2 | Merge branch 'main' into feature/openid-federation... | Skipped: sign-off not required in merge commit |
🟢 | d5ea627 | update lock | Valid sign-off found |
🟢 | 94d22bd | fix: Use the right fingerprint for the RP kid | Valid sign-off found |
🟢 | 11455b5 | fix: OpenID Federation small fixes (#2099) | Valid sign-off found |
🔴 | 367dfa2 | chore: Update branch with main (#2106) | No sign-off matches the author or committer |
🟢 | ff73f53 | Merge branch 'main' into feature/openid-federation... | Skipped: sign-off not required in merge commit |
🟢 | 274b421 | update lockfile | Valid sign-off found |
🟢 | 8da4250 | feat: Support for subordinate entities and authori... | Valid sign-off found |
🟢 | 262ee63 | Merge branch 'feature/openid-federation-verfier--o... | Skipped: sign-off not required in merge commit |
🟢 | 623c3b7 | fix: Apply withEntityId patch for the normal versi... | Valid sign-off found |
🟢 | c3939b2 | chore: Bumped the federation package | Valid sign-off found |
🟢 | 8628b5e | fix: changed clientName into client_name | Valid sign-off found |
🟢 | 5f0b11a | fix: Search the jwk based on the kid | Valid sign-off found |
Errors details
No sign-off matches the author or committer
A valid sign-off was found in the commit message, but it doesn't match neither the author nor the committer. Make sure that both the name and email in the sign-off line match the author or committer of the commit.
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~23 --signoff
- Force push your changes to overwrite the branch:
git push --force-with-lease origin feature/openid-federation-verfier