fix: svg res work error in <img> tag #601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifei8
force-pushed
the
fix/svg_img_error
branch
from
48b3d85
to
52a5d37
Compare
| @@ -73,7 +73,9 @@ class SVGRenderBoxBuilder { | |||
| .toDartString(length: element.original_tag.length) | |||
| .toUpperCase(); | |||
| final renderBox = getSVGRenderBox(tagName); | |||
|
|
|||
| if (renderBox == null) { | |||
| return false; | |||
There was a problem hiding this comment.
Is it more suitable to return a null value when the renderBox is null, as the expected value of visitSVGTree is RenderBoxModel ?
There was a problem hiding this comment.
It shouldn't be necessary. You can take a look at this complete code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.