Feat: Full support of CanvasContext2D.Path2D

bridge/CMakeLists.txt

@@ -411,8 +411,11 @@ if (${WEBF_JS_ENGINE} MATCHES "quickjs")
     core/html/canvas/canvas_rendering_context_2d.cc
     core/html/canvas/canvas_gradient.cc
     core/html/canvas/canvas_pattern.cc
+    core/html/canvas/path_2d.cc
     core/geometry/dom_matrix.cc
-    core/geometry/dom_matrix_readonly.cc
+    core/geometry/dom_matrix_read_only.cc
+    core/geometry/dom_point.cc
+    core/geometry/dom_point_read_only.cc
     core/html/forms/html_button_element.cc
     core/html/forms/html_input_element.cc
     core/html/forms/html_form_element.cc
@@ -545,11 +548,18 @@ if (${WEBF_JS_ENGINE} MATCHES "quickjs")
     out/qjs_canvas_rendering_context.cc
     out/qjs_canvas_gradient.cc
     out/qjs_canvas_pattern.cc
+    out/qjs_path_2d.cc
+    out/qjs_dom_matrix_init.cc
     out/qjs_dom_matrix.cc
-    out/qjs_dom_matrix_readonly.cc
-    out/qjs_union_dom_string_sequencedouble.cc
+    out/qjs_dom_matrix_read_only.cc
+    out/qjs_dom_point_init.cc
+    out/qjs_dom_point.cc
+    out/qjs_dom_point_read_only.cc
+    out/qjs_union_double_sequencedouble.cc
     out/qjs_unionhtml_image_elementhtml_canvas_element.cc
     out/qjs_union_dom_stringcanvas_gradient.cc
+    out/qjs_union_sequencedoubledom_matrix_init.cc
+    out/qjs_union_doubledom_point_init.cc
     out/canvas_types.cc
     out/qjs_html_button_element.cc
     out/qjs_html_input_element.cc
@@ -560,6 +570,7 @@ if (${WEBF_JS_ENGINE} MATCHES "quickjs")
     out/qjs_promise_rejection_event_init.cc
     out/qjs_unionevent_listener_options_boolean.cc
     out/qjs_unionadd_event_listener_options_boolean.cc
+    out/qjs_unionpath_2_d_dom_string.cc
     out/qjs_html_template_element.cc
     out/qjs_html_unknown_element.cc
     out/qjs_performance.cc

bridge/bindings/qjs/binding_initializer.cc

@@ -11,6 +11,7 @@
 #include "qjs_bounding_client_rect.h"
 #include "qjs_canvas_gradient.h"
 #include "qjs_canvas_pattern.h"
+#include "qjs_path_2d.h"
 #include "qjs_canvas_rendering_context.h"
 #include "qjs_canvas_rendering_context_2d.h"
 #include "qjs_character_data.h"
@@ -23,7 +24,9 @@
 #include "qjs_document.h"
 #include "qjs_document_fragment.h"
 #include "qjs_dom_matrix.h"
-#include "qjs_dom_matrix_readonly.h"
+#include "qjs_dom_matrix_read_only.h"
+#include "qjs_dom_point.h"
+#include "qjs_dom_point_read_only.h"
 #include "qjs_dom_string_map.h"
 #include "qjs_dom_token_list.h"
 #include "qjs_element.h"
@@ -163,8 +166,11 @@ void InstallBindings(ExecutingContext* context) {
   QJSCanvasRenderingContext2D::Install(context);
   QJSCanvasPattern::Install(context);
   QJSCanvasGradient::Install(context);
-  QJSDOMMatrixReadonly::Install(context);
+  QJSPath2D::Install(context);
+  QJSDOMMatrixReadOnly::Install(context);
   QJSDOMMatrix::Install(context);
+  QJSDOMPointReadOnly::Install(context);
+  QJSDOMPoint::Install(context);
   QJSCSSStyleDeclaration::Install(context);
   QJSInlineCssStyleDeclaration::Install(context);
   QJSComputedCssStyleDeclaration::Install(context);

bridge/bindings/qjs/wrapper_type_info.h

@@ -79,8 +79,11 @@ enum {
   JS_CLASS_CANVAS_RENDERING_CONTEXT_2_D,
   JS_CLASS_CANVAS_GRADIENT,
   JS_CLASS_CANVAS_PATTERN,
+  JS_CLASS_PATH_2_D,
   JS_CLASS_DOM_MATRIX,
-  JS_CLASS_DOM_MATRIX_READONLY,
+  JS_CLASS_DOM_MATRIX_READ_ONLY,
+  JS_CLASS_DOM_POINT,
+  JS_CLASS_DOM_POINT_READ_ONLY,
   JS_CLASS_HTML_TEMPLATE_ELEMENT,
   JS_CLASS_HTML_UNKNOWN_ELEMENT,
   JS_CLASS_HTML_INPUT_ELEMENT,

bridge/core/binding_call_methods.json5

@@ -45,6 +45,7 @@
     "x",
     "y",
     "z",
+    "w",
     "screen",
     "target",
     "accessKey",
@@ -104,6 +105,7 @@
     "lineTo",
     "moveTo",
     "rect",
+    "roundRect",
     "restore",
     "resetTransform",
     "rotate",
@@ -114,6 +116,7 @@
     "scale",
     "strokeText",
     "setTransform",
+    "addPath",
     "transform",
     "translate",
     "reset",
@@ -179,6 +182,46 @@
     "dir",
     "pageXOffset",
     "pageYOffset",
-    "title"
+    "title",
+    "is2D",
+    "isIdentity",
+    "m11",
+    "m12",
+    "m13",
+    "m14",
+    "m21",
+    "m22",
+    "m23",
+    "m24",
+    "m31",
+    "m32",
+    "m33",
+    "m34",
+    "m41",
+    "m42",
+    "m43",
+    "m44",
+    "a",
+    "b",
+    "c",
+    "d",
+    "e",
+    "f",
+    "flipX",
+    "flipY",
+    "inverse",
+    "multiply",
+    "rotateAxisAngle",
+    "rotateFromVector",
+    "scale3d",
+    "scaleNonUniform",
+    "skewX",
+    "skewY",
+    "toFloat32Array",
+    "toFloat64Array",
+    "toJSON",
+    "toString",
+    "transformPoint",
+    "matrixTransform"
   ]
 }

bridge/core/binding_object.h

@@ -70,7 +70,11 @@ enum BindingMethodCallOperations {
   kAsyncAnonymousFunction,
 };
 
-enum CreateBindingObjectType { kCreateDOMMatrix = 0 };
+enum CreateBindingObjectType { 
+  kCreateDOMMatrix = 0,
+  kCreatePath2D = 1,
+  kCreateDOMPoint = 2,
+};
 
 struct BindingObjectPromiseContext : public DartReadable {
   ExecutingContext* context;

bridge/core/frame/module_manager.cc

@@ -138,10 +138,25 @@ ScriptValue ModuleManager::__webf_invoke_module__(ExecutingContext* context,
                                                   ExceptionState& exception) {
   NativeValue params = params_value.ToNative(context->ctx(), exception);
 
-  if (exception.HasException()) {
+  NativeValue* result = __webf_invoke_module__(context, module_name, method, params, callback, exception);
+  if (result == nullptr) {
     return ScriptValue::Empty(context->ctx());
   }
 
+  ScriptValue return_value = ScriptValue(context->ctx(), *result);
+  dart_free(result);
+  return return_value;
+}
+NativeValue* ModuleManager::__webf_invoke_module__(ExecutingContext* context,
+                                                  const AtomicString& module_name,
+                                                  const AtomicString& method,
+                                                  NativeValue& params,
+                                                  const std::shared_ptr<QJSFunction>& callback,
+                                                  ExceptionState& exception) {
+  if (exception.HasException()) {
+    return nullptr;
+  }
+
   NativeValue* result;
   auto module_name_string = module_name.ToNativeString(context->ctx());
   auto method_name_string = method.ToNativeString(context->ctx());
@@ -165,12 +180,12 @@ ScriptValue ModuleManager::__webf_invoke_module__(ExecutingContext* context,
   context->dartIsolateContext()->profiler()->FinishTrackLinkSteps();
 
   if (result == nullptr) {
-    return ScriptValue::Empty(context->ctx());
+    return nullptr;
   }
 
-  ScriptValue return_value = ScriptValue(context->ctx(), *result);
-  dart_free(result);
-  return return_value;
+  // ScriptValue return_value = ScriptValue(context->ctx(), *result);
+  // dart_free(result);
+  return result;
 }
 
 void ModuleManager::__webf_add_module_listener__(ExecutingContext* context,

bridge/core/frame/module_manager.h

@@ -10,6 +10,8 @@
 #include "bindings/qjs/qjs_function.h"
 #include "module_callback.h"
 
+#include <webf_bridge.h>
+
 namespace webf {
 
 class ModuleContext {
@@ -37,6 +39,12 @@ class ModuleManager {
                                             ScriptValue& params_value,
                                             const std::shared_ptr<QJSFunction>& callback,
                                             ExceptionState& exception);
+  static NativeValue* __webf_invoke_module__(ExecutingContext* context,
+                                             const AtomicString& module_name,
+                                             const AtomicString& method,
+                                             NativeValue& params_value,
+                                             const std::shared_ptr<QJSFunction>& callback,
+                                             ExceptionState& exception);
   static void __webf_add_module_listener__(ExecutingContext* context,
                                            const AtomicString& module_name,
                                            const std::shared_ptr<QJSFunction>& handler,

bridge/core/geometry/dom_matrix.cc

@@ -3,18 +3,30 @@
  */
 
 #include "dom_matrix.h"
+#include "core/executing_context.h"
 
 namespace webf {
 
 DOMMatrix* DOMMatrix::Create(ExecutingContext* context,
-                             const std::shared_ptr<QJSUnionDomStringSequenceDouble>& init,
+                             const std::shared_ptr<QJSUnionSequenceDoubleDOMMatrixInit>& init,
                              ExceptionState& exception_state) {
   return MakeGarbageCollected<DOMMatrix>(context, init, exception_state);
 }
 
+DOMMatrix* DOMMatrix::Create(webf::ExecutingContext* context, webf::ExceptionState& exception_state) {
+  return MakeGarbageCollected<DOMMatrix>(context, exception_state);
+}
+
+DOMMatrix::DOMMatrix(webf::ExecutingContext* context, webf::ExceptionState& exception_state):
+      DOMMatrixReadOnly(context, exception_state) {}
+
 DOMMatrix::DOMMatrix(ExecutingContext* context,
-                     const std::shared_ptr<QJSUnionDomStringSequenceDouble>& init,
+                     const std::shared_ptr<QJSUnionSequenceDoubleDOMMatrixInit>& init,
                      ExceptionState& exception_state)
-    : DOMMatrixReadonly(context, init, exception_state) {}
+    : DOMMatrixReadOnly(context, init, exception_state) {}
+
+DOMMatrix::DOMMatrix(webf::ExecutingContext* context, webf::NativeBindingObject* native_binding_object): DOMMatrixReadOnly(context, native_binding_object) {
+
+}
 
 }  // namespace webf

bridge/core/geometry/dom_matrix.d.ts

@@ -1,3 +1,7 @@
-interface DOMMatrix extends DOMMatrixReadonly {
-  new(init: string | double[]): DOMMatrix;
+import {DOMMatrixInit} from "./dom_matrix_init";
+import {DOMMatrixReadOnly} from "./dom_matrix_read_only";
+
+interface DOMMatrix extends DOMMatrixReadOnly {
+    fromMatrix(matrix: DOMMatrix): StaticMethod<DOMMatrix>;
+    new(init?: number[] | DOMMatrixInit): DOMMatrix;
 }

bridge/core/geometry/dom_matrix.h

@@ -5,25 +5,39 @@
 #ifndef WEBF_CORE_HTML_CANVAS_DOM_MATRIX_H_
 #define WEBF_CORE_HTML_CANVAS_DOM_MATRIX_H_
 
-#include "dom_matrix_readonly.h"
+#include "dom_matrix_read_only.h"
 
 namespace webf {
 
-class DOMMatrix : public DOMMatrixReadonly {
+class DOMMatrix : public DOMMatrixReadOnly {
   DEFINE_WRAPPERTYPEINFO();
 
  public:
+  using ImplType = DOMMatrix*;
+  static DOMMatrix* Create(ExecutingContext* context,
+                           const std::shared_ptr<QJSUnionSequenceDoubleDOMMatrixInit>& init,
+                           ExceptionState& exception_state);
   static DOMMatrix* Create(ExecutingContext* context,
-                           const std::shared_ptr<QJSUnionDomStringSequenceDouble>& init,
                            ExceptionState& exception_state);
 
   DOMMatrix() = delete;
   explicit DOMMatrix(ExecutingContext* context,
-                     const std::shared_ptr<QJSUnionDomStringSequenceDouble>& init,
                      ExceptionState& exception_state);
+  explicit DOMMatrix(ExecutingContext* context,
+                     const std::shared_ptr<QJSUnionSequenceDoubleDOMMatrixInit>& init,
+                     ExceptionState& exception_state);
+  explicit DOMMatrix(ExecutingContext* context,
+                     NativeBindingObject* native_binding_object);
+
+  [[nodiscard]]
+  bool IsDOMMatrix() const override { return true; }
 
  private:
 };
+template <>
+struct DowncastTraits<DOMMatrix> {
+  static bool AllowFrom(const DOMMatrixReadOnly& matrix) { return matrix.IsDOMMatrix(); }
+};
 
 }  // namespace webf
 

bridge/core/geometry/dom_matrix_init.d.ts

@@ -0,0 +1,22 @@
+// @ts-ignore
+@Dictionary()
+export interface DOMMatrixInit {
+    m11: number,
+    m12: number,
+    m13: number,
+    m14: number,
+    m21: number,
+    m22: number,
+    m23: number,
+    m24: number,
+    m31: number,
+    m32: number,
+    m33: number,
+    m34: number,
+    m41: number,
+    m42: number,
+    m43: number,
+    m44: number,
+    is2D: boolean,
+    isIdentity: boolean,
+}