Add additional methods and tests for numerical methods. #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstaabp
force-pushed
the
add-numeric-methods
branch
from
83bb008 to
b42c85c
Compare
|
Can you remind me how to execute the tests? Then I'll do that to confirm it all works on my setup. Since these are all new methods (some of which I am not familiar with mathematically) I would then just approve without further inspection. Well, I might load the POD and read it and look for suggestions, but I am not sure I would review the actual method code. |
|
Execute |
|
If you want to run only the tests in this pull request you can also do |
This adds methods for newtonDividedDifference, Legendre Polynomials, Newton-Cotes quadrature, Gaussian Quadrature, numerical differential equation solvers, and rootfinding techniques. u
pstaabp
force-pushed
the
add-numeric-methods
branch
from
f64e282 to
c179bc1
Compare
|
Rebased on PG-2.20, merged a PR from @Alex-Jordan and more cleanup. |
Alex-Jordan
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds methods for newtonDividedDifference, Legendre Polynomials, Newton-Cotes quadrature, Gaussian Quadrature, numerical differential equation solvers, and rootfinding techniques.
There also adds tests for all these methods. This builds on #1022.