Change the version to 2.20 and remove the license from files. #2722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
version-update
branch
from
87209e6 to
df8d719
Compare
There is no need for the license to be in all files. That creates an unnecessary maintenance hassle with keeping the copyright years up to date, and it is sufficient to have the license (with the copyright years) in the `LICENSE` file alone. Furthermore, this is done quite inconsistently. Sometimes files are added without the license, and potentially worse is a file being added with the license but not in the exact format needed for the `bin/dev_scripts/update-copyright` script to detect and properly update the copyright years. The `bin/dev_scripts/update-copyright` script is thus no longer needed and has been removed. Also, the fallback copyright years for the footer now is just "unknown" instead of being the correct copyright years. If the version and copyright years are not correctly loaded in the course environment from the `VERSION` file then that is what you will see. That should never happen. So from now on the only files that need to be updated are the `LICENSE`, `README.md`, and `VERSION` files. In addition the `docker-config/docker-compose.dist.yml` and `DockerfileStage2` files need to have `forWW...` tag name updated to the current version (for the two stage build).
drgrice1
force-pushed
the
version-update
branch
from
df8d719 to
1a06128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for the license to be in all files. That creates an unnecessary maintenance hassle with keeping the copyright years up to date, and it is sufficient to have the license (with the copyright years) in the
LICENSEfile alone. Furthermore, this is done quite inconsistently. Sometimes files are added without the license, and potentially worse is a file being added with the license but not in the exact format needed for thebin/dev_scripts/update-copyrightscript to detect and properly update the copyright years. Thebin/dev_scripts/update-copyrightscript is thus no longer needed and has been removed.Also, the fallback copyright years for the footer now is just "unknown" instead of being the correct copyright years. If the version and copyright years are not correctly loaded in the course environment from the
VERSIONfile then that is what you will see. That should never happen.So from now on the only files that need to be updated are the
LICENSE,README.md, andVERSIONfiles. In addition thedocker-config/docker-compose.dist.ymlandDockerfileStage2files need to haveforWW...tag name updated to the current version (for the two stage build).