Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Added support for device deactivation #560 #607

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Aug 2, 2024

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens to the monitoring status of a device when it gets deactivated?
I was expecting to see some logic which would see some logic for the following:

  • Making sure monitoring checks are not run
  • Setting monitoring status to "UNKNOWN". Or, we can use a special status for this e,g, "DEACTIVATED" - I think "DEACTIVATED" is more explicit and preferable for UX
  • Replying with 404 for monitoring requests

I would also add that activating a device must reverse this: checks are run again, hence monitoring status should automatically become either OK or CRITICAL and device metrics shall be accepted.

We need tu update the docs to reflect these changes.

Please rebase on the latest master and reformat code if necessary.

@pandafy pandafy force-pushed the issues/560-deactivating-device branch from fd72d0e to 440d04c Compare August 8, 2024 18:37
@pandafy pandafy force-pushed the issues/560-deactivating-device branch from 8c668ae to 833656a Compare August 9, 2024 17:21
@pandafy pandafy force-pushed the issues/560-deactivating-device branch from 833656a to b584a40 Compare August 9, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Deactivating device should also disable monitoring
2 participants