Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Geppetto version of muscle model #32

Open
slarson opened this issue Feb 8, 2015 · 3 comments
Open

Improve Geppetto version of muscle model #32

slarson opened this issue Feb 8, 2015 · 3 comments

Comments

@slarson
Copy link
Member

slarson commented Feb 8, 2015

A first version of the muscle model is currently out on live.geppetto.org under the default samples. There are still several things that need improving with this. I've asked several questions over in the geppetto samples repo to hopefully get responses from that team on how we can make several of these improvements ourselves:

openworm/org.geppetto.samples#23
openworm/org.geppetto.samples#24
openworm/org.geppetto.samples#25
openworm/org.geppetto.samples#26
openworm/org.geppetto.samples#27

As they get answered, I'll be updating this issue and spinning out some more specific issues to fix each point raised by the questions.

@tarelli
Copy link
Member

tarelli commented Feb 8, 2015

@slarson thanks for the cards, I replied to all of them, if anyone would like to help out with the features that still need to be implemented/documented don't be shy :)

@tarelli
Copy link
Member

tarelli commented Feb 8, 2015

This file is where the logic of what happens in the sample exists: https://github.com/openworm/org.geppetto.samples/blob/development/LEMS/MuscleModel/script.js
Feel free to fork/ create PR to improve the sample!

@slarson
Copy link
Member Author

slarson commented Feb 8, 2015

@tarelli Thanks for this! I have created a pull request openworm/org.geppetto.samples#28 to kick off the popup for openworm/org.geppetto.samples#23 Thanks for your fix for openworm/org.geppetto.samples#24. We'll keep iterating on the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants