Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket reconnection ensure data got lost and then trigger reload #905

Open
ddelpiano opened this issue Mar 1, 2021 · 1 comment
Open

Comments

@ddelpiano
Copy link
Contributor

Just discussed in the VFB sprint with Robbie, he is testing this closing the websocket and noticed that the reconnection is then associated to a new geppettoManager, in principle this is fine since that logic is meant to work with unexpected lost connection that will have a return code different from a closed websocket.
However, what we need to do geppetto wise is to check if the geppettoManager we are trying to resume is still existing, if not force the frontend to trigger a reload since the data are not available.

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant