build: allow to define additional configs #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the failing test. |
a-gave
force-pushed
the
feat/allow-to-define-additional-configs
branch
from
3ef4de3
to
60b45b9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 80.94% 86.70% +5.75%
==========================================
Files 15 15
Lines 976 985 +9
==========================================
+ Hits 790 854 +64
+ Misses 186 131 -55 ☔ View full report in Codecov by Sentry. |
aparcar
force-pushed
the
feat/allow-to-define-additional-configs
branch
from
60b45b9
to
88f632b
Compare
|
What is the status of this PR? |
|
I'm not a huge fan to allow arbitrary changes but since we moved into containers, it might be fine. Is anyone interested in using this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the possibility of passing additional configs to the request.
Only the few not related to kernel/packages, as they are not recompiled by the imagebuilder, would make sense.
For example, to request a specific name/number for a firmware image:
Or to request a format other than the default format for the output firmware image, for example: