Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,travis: add script from openwrt/packages.git #1317

Closed
wants to merge 1 commit into from

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Aug 19, 2017

add .travis.yml and a slightly modiefied .travis_do.sh to fit the
luci.git repository structure.

Builds all changed packages of the applications/ folder.

Script is adapted from openwrt/packages.git based on @lynxis work.

Changes of script are mostly:

  • 68: PKGS var is set differently due auto versioning of luci packages
  • 88: use Githubs openwrt/packages.git as feed
  • 101, 112: no need to parse pkg_name
  • 186: use different first commit hash

Signed-off-by: Paul Spooren [email protected]

@aparcar aparcar force-pushed the travis branch 2 times, most recently from c345514 to e37e896 Compare August 20, 2017 19:18
@lynxis
Copy link
Member

lynxis commented Aug 27, 2017

@aparcar:

  • line 68: I don't like to filter only for applications
  • line 88: ok.
  • line 101/112: why do you removed it?
  • linue 186: ok

@aparcar aparcar force-pushed the travis branch 5 times, most recently from 19da14a to 8505dab Compare August 30, 2017 18:28
@aparcar
Copy link
Member Author

aparcar commented Aug 30, 2017

@lynxis

  • line 68: I don't like to filter only for applications
    It's changed to applications/collections/contrib/libs/modules/protocols/themes
  • line 88: ok.
  • line 101/112: why do you removed it?
    It's set via line 68, no need for any further modifications.
  • line 186: ok

@hnyman
Copy link
Contributor

hnyman commented Sep 2, 2017

@jow-
any thoughts on activating travis also here in LuCI, like on packages feed?

@lynxis @champtar
Any further comments from the travis specialists?

@lynxis
Copy link
Member

lynxis commented Sep 3, 2017

@aparcar why do you want to filter the files? Do you have any example when the script would otherwise fail?

@aparcar
Copy link
Member Author

aparcar commented Sep 3, 2017

@lynxis the other folders do not contain Makefiles so I thought no packages can result -> nothing to build

@aparcar aparcar force-pushed the travis branch 5 times, most recently from 94a517e to f9c4d01 Compare September 3, 2017 19:03
add .travis.yml and a slightly modiefied .travis_do.sh to fit the
luci.git repository structure.

Builds all changed packages of the applications/ folder.

Script is adapted from openwrt/packages.git based on @lynxis work.

Changes of script are mostly:

* 68: PKGS var is set differently due auto versioning of luci packages
* 88: use Githubs openwrt/packages.git as feed
* 101, 112: no need to parse pkg_name
* 188: generic first hash

Signed-off-by: Paul Spooren <[email protected]>
@aparcar
Copy link
Member Author

aparcar commented Sep 3, 2017

@lynxis please see line 188. It reads the first commit id so it could be used for packages.git as well.

@lynxis
Copy link
Member

lynxis commented Sep 3, 2017

@aparcar LGTM. Do you tested it?

@aparcar
Copy link
Member Author

aparcar commented Sep 3, 2017

@lynxis yes I created this rather useless PR for testing. It changes packages/files at different locations. The scripts finds all changes correctly.

@lynxis
Copy link
Member

lynxis commented Sep 3, 2017

thanks for your work!

@champtar
Copy link
Member

champtar commented Sep 5, 2017

Hi @aparcar
Just want to double check that the FIRST_COMMIT_ID works in all cases.
Also maybe we can make this script generic enough to share it between repos?

@aparcar
Copy link
Member Author

aparcar commented Nov 20, 2017

@champtar what do you mean with all cases? I tried it and it works as (I) expected.

I started on a more generic approach but it got a bit messy as https://github.com/openwrt-routing/packages uses a different structure/depth of packages.
There where some ideas about merging to openwrt/packages but stopped for a while openwrt/routing#184

@feckert
Copy link
Member

feckert commented Aug 2, 2019

I think this could be closed because of
da35bfc#diff-df4a0e327b62c8cc393e4f285d1d86e4

@aparcar
Copy link
Member Author

aparcar commented Aug 2, 2019

@feckert thanks for reviewing, when I created the other PR I totally forgot about this one!

@aparcar aparcar closed this Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants