Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luci-app-ddns: avoid Absent Interface: "wan" when the physical device does not exist #7555

Merged
merged 1 commit into from
Jan 22, 2025
Merged

luci-app-ddns: avoid Absent Interface: "wan" when the physical device does not exist #7555

merged 1 commit into from
Jan 22, 2025

Conversation

adelton
Copy link
Contributor

@adelton adelton commented Jan 10, 2025 •
edited
Loading

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <[email protected]> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: a x86_64 VM with OpenWrt 24.10.0-rc5 (r28304-6dacba30a7)
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
    Screenshot_2025-01-10_21-07-55
  • ( Optional ) Closes mod-app-ddns: Absent Interface: "wan" shown by default for the Interface IP address source #7554
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: avoid Absent Interface: "wan" -- when the physical device does not exist, the Alias Interface is likely what we want for the default.

@adelton adelton marked this pull request as draft January 10, 2025 20:48
@adelton
luci-app-ddns: avoid Absent Interface: "wan" when it does not exist
02e6c4a 
and the Alias Interface is likely what we want for the default.

Signed-off-by: Jan Pazdziora <[email protected]>
@adelton adelton marked this pull request as ready for review January 12, 2025 08:08
@adelton adelton changed the title luci-app-ddns: avoid Absent Interface: "wan" when the Alias Interface is likely what we want for the default. luci-app-ddns: avoid Absent Interface: "wan" when the physical device does not exist Jan 12, 2025
@adelton adelton mentioned this pull request Jan 12, 2025
Open
1 task
@systemcrash systemcrash merged commit 9e10f25 into openwrt:master Jan 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adelton @systemcrash