Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xl2pd: fixed segmentation fault at start #19151

Closed
wants to merge 1 commit into from
Closed

xl2pd: fixed segmentation fault at start #19151

wants to merge 1 commit into from

Conversation

nevapadonak
Copy link

Maintainer: me
Compile tested: ARM Cortex-A7, Freescale i.MX 6 ULL, OpenWRT v21.02.0
Run tested: same

Description:
xelerance/xl2tpd#243

@nevapadonak nevapadonak changed the title Fixed bug: https://github.com/xelerance/xl2tpd/issues/243 xl2pd: fixed bug Aug 12, 2022
@feckert
Copy link
Member

feckert commented Aug 12, 2022

Please use a valid commit header in your commit:
xl2pd: <Describe what you are fixing>
Please use a valid Signed-off-by: firstname lastname <[email protected]>

@nevapadonak nevapadonak changed the title xl2pd: fixed bug xl2pd: fixed bug (Segmentation Fault on some systems) Aug 12, 2022
@nevapadonak nevapadonak changed the title xl2pd: fixed bug (Segmentation Fault on some systems) xl2pd: fixed bug (Segmentation Fault at start on some systems) Aug 12, 2022
@nevapadonak nevapadonak force-pushed the xl2tpd branch 2 times, most recently from 31db993 to 8732510 Compare August 12, 2022 13:56
@nevapadonak
Copy link
Author

Please use a valid commit header in your commit: xl2pd: <Describe what you are fixing> Please use a valid Signed-off-by: firstname lastname <[email protected]>

Done.

@feckert
Copy link
Member

feckert commented Aug 12, 2022

If this is the case, then I would suggest that the commit message looks like this.
xl2pd: fixed segmentation fault at start
Are you planning to send this to the upstream project as well?

@nevapadonak nevapadonak changed the title xl2pd: fixed bug (Segmentation Fault at start on some systems) xl2pd: fixed segmentation fault at start Aug 12, 2022
@nevapadonak
Copy link
Author

nevapadonak commented Aug 12, 2022 •
edited
Loading

If this is the case, then I would suggest that the commit message looks like this. xl2pd: fixed segmentation fault at start Are you planning to send this to the upstream project as well?

I fixed the commit message as you've adviced.

I also sent this to the upstream project:
xelerance/xl2tpd#243

Current Pull Request is needed anyway.

@feckert
Copy link
Member

feckert commented Aug 12, 2022

Sorry but this was the pullrequest message.

@nevapadonak
Copy link
Author

Sorry but this was the pullrequest message.

?

@nevapadonak nevapadonak deleted the xl2tpd branch August 15, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nevapadonak @feckert