Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prometheus exporter for Modem Manager Signal #25283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

macjl
Copy link

@macjl macjl commented Nov 9, 2024

Maintainer: Jean-Laurent Girod
Compile tested: No compile test done
Run tested: ath79/generic, GL.inet GL-X300B, OpenWrt 23.05.5

Description:
Add a prometheus exporter that rely on modemmanager to provide signal strength informations.

@feckert
Copy link
Member

feckert commented Nov 11, 2024

Please use one commit for this change, and also change the commit header to prometheus-node-exporter-lua: add modemmanager exporter.
How does the exporter behave if there is more than one modem in the system?

Please have in mind, that if the modem is reattached The object ID in the ModemMananager Service is increment by one on every reattach. Is this handled by your code correctly?

@macjl
Copy link
Author

macjl commented Nov 13, 2024

Please use one commit for this change, and also change the commit header to prometheus-node-exporter-lua: add modemmanager exporter.

This is done !

How does the exporter behave if there is more than one modem in the system?
Please have in mind, that if the modem is reattached The object ID in the ModemMananager Service is increment by one on every reattach. Is this handled by your code correctly?

I don’t found any informations about the output of mmcli command when there are 2 modems, as I just have one modem to test it. Is there a way I could simulate a second one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants