Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frr: add FRRouting, a Quagga fork #319

Closed
wants to merge 1 commit into from
Closed

Conversation

lucize
Copy link

@lucize lucize commented Aug 13, 2017

this version is the initial release for LEDE/OpenWRT

Mantainer: ME
Compile/Run Tested: x86_64, sunxi, mips

Signed-off-by: Lucian Cristian [email protected]

@lucize lucize changed the title frr: [RFC] add FFRouting 3.0-rc1, a Quagga fork frr: add FFRouting 3.0, a Quagga fork Oct 13, 2017
@lucize
Copy link
Author

lucize commented Oct 13, 2017

@jow- frr reached 3.0 stable, can we have this in ?
I'll try to finish backporting eigrp, 3.0 already has nhrp so maybe soon we can replace some CISCO routers by LEDE
Also Quagga is a bit outdated

@lucize
Copy link
Author

lucize commented Oct 17, 2017

@diizzyy @acinonyx someone an input ?

@lucize lucize changed the title frr: add FFRouting 3.0, a Quagga fork frr: add FRRouting 3.0, a Quagga fork Oct 17, 2017
@diizzyy
Copy link
Contributor

diizzyy commented Oct 17, 2017

I'm not a user but how does this compare to quagga (which still seems active)?
FFRouting seems also like a quite new project as far as I can tell ( https://www.linux.com/news/2017/4/welcoming-frrouting-linux-foundation ) and I'm not sure what more it offers running on OpenWRT/LEDE compared to bird/quagga except being yet another alternative?

@lucize
Copy link
Author

lucize commented Oct 18, 2017

Quagga is quite stalled also see statement and the reccent issue #299 solved by this version
To be honest 3.1 will be a major update to quagga, there is much development happening see.
For now 3.1 has some problems with cross compile regarding python-devel needed on the host but the problem is planned to be addressed

@acinonyx
Copy link
Contributor

Please, also read https://lists.gt.net/quagga/users/32627 . @pjakma is expressing concerns on how FRR distributes Quagga source code.

@lucize
Copy link
Author

lucize commented Oct 22, 2017

but I don't see any detail about that, as they further discussed on the mailinglist and I don't think that we should concern about that, if that will happen then FRR should take care of that
that means that I should not use the single EIGRP alternative out there because someone in the mailing list has some concerns without showing actual data ?

@pjakma
Copy link

pjakma commented Oct 23, 2017 via email

@pjakma
Copy link

pjakma commented Oct 23, 2017 via email

@pjakma
Copy link

pjakma commented Oct 23, 2017

Given someone decided to link to The Register article that is very one-sided (and contains highly misleading statements):

https://lwn.net/Articles/718859/
https://lists.quagga.net/pipermail/quagga-dev/2017-April/033225.html

Missing from the above, that I could not state until recently, due to implicit threats by my former employer:

https://lists.quagga.net/pipermail/quagga-dev/2017-October/033285.html

@lucize
Copy link
Author

lucize commented Oct 23, 2017

I don't want to state who's whom, weren't on the loop with things, this is just a Makefile that is using the source code available on github having more options from other open source projects

side notes: this is thing is not good for anyone, and if legal actions needs to be made, as an end user, should we just wait and see IF someday this will be addressed ?

@lucize lucize changed the title frr: add FRRouting 3.0, a Quagga fork frr: add FRRouting 5.0.1, a Quagga fork Aug 23, 2018
@lucize
Copy link
Author

lucize commented Aug 23, 2018

Updated to stable 5.0.1 there are some small changes to be done and it will be ready

Hopefully now has a clear advantage over the existing alternatives

@cfra
Copy link

cfra commented Aug 23, 2018

I have tested this package, and all in all, it seems to work well.

There are some smaller nits which I found:

a) more is absent, a different pager needs to be used. Trying out the different options, I found that cat was indeed the most usable option, since busybox's less apparently always start out with clearing the screen, which makes interactive use very annoying

The pager can be set with configure by now, I have added --with-vtysh-pager=cat to the configure statement and it works fine now. If one really wants to go with less at least less -F -~ should be chosen so that it doesn't wait if the output fits on a single screen.

b) ldpd is not in the daemon list in /usr/sbin/frr.init, so it is not getting started automatically

c) pbrd is missing from the package

@pjakma
Copy link

pjakma commented Aug 23, 2018 via email

@lucize
Copy link
Author

lucize commented Aug 25, 2018

@cfra updated, maybe you can see why the syslog repeats

restart /usr/sbin/frr.init watchrestart process <x> exited with non-zero status 2

or maybe is the intended behavior

@cfra
Copy link

cfra commented Aug 25, 2018

@lucize this is actually happening because watchfrr was getting called in a weird way. I have fixed it here: cfra@32b2115 - feel free to use this commit as cherry-pick or fixup.

@lucize
Copy link
Author

lucize commented Aug 25, 2018

@cfra cherry-picked

@CHKDSK88
Copy link

What is current legal status of frr? I saw some licenses changes commits durring last time.

Is still license problem?

@lucize
Copy link
Author

lucize commented Jan 22, 2019

I have the 7-dev on my tree if someone needs it, i'll update the PR

@pjakma
Copy link

pjakma commented Jan 22, 2019 via email

@CHKDSK88
Copy link

@pjakma

Sorry, but I don't understand. FRR is distributed under GPL. I'm confused.

@lucize lucize changed the title frr: add FRRouting 5.0.1, a Quagga fork frr: add FRRouting, a Quagga fork Mar 22, 2019
@lucize lucize force-pushed the frr branch 2 times, most recently from 571a8dd to 03ca7fa Compare June 9, 2019 16:33
FRRouting is free software that implements and manages various IPv4 and IPv6
routing protocols.

Currently FRRouting supports BGP4, BGP4+, BFD, OSPFv2, OSPFv3, RIPv1, RIPv2, RIPng,
IS-IS, PIM-SM/MSDP, LDP, OpenFabric, VRRP and Babel as well as very early support
for EIGRP and NHRP.

https://github.com/FRRouting/frr/wiki

Signed-off-by: Lucian Cristian <[email protected]>
@c-x-berger
Copy link

c-x-berger commented Dec 15, 2020

Those who have lost their licence can not regain a licence by unilateral
changes on their side.

Interesting.

The closest thing Quagga has to a working homepage right now specifies it is available under "GNU General Public License v2 or later".

This might be convenient for the FRRouting folks, since GPLv3 explicitly re-grants license rights in Section 8, paragraph 2:

However, if you cease all violation of this License, then your license from a particular copyright holder is reinstated (a) provisionally, unless and until the copyright holder explicitly and finally terminates your license, and (b) permanently, if the copyright holder fails to notify you of the violation by some reasonable means prior to 60 days after the cessation.

I say "might" because FRRouting is GPLv2, not v3, and I have no idea if distributing a derivative of v3 software as v2 is legal.

Though it seems overall that the decision has already been made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants