Crypto trait in the high level interface and EAD #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are added trivially (all just say "Crypto"), and this eases their use in other objects that otherwise need manual Debug implementations.
chrysn
force-pushed
the
more-crypto-trait
branch
from
14c934b to
180b8d1
Compare
This allows pushing back the edhoc-crypto ("the default implementation
that is selected statically, making all implementations possible
dependencies") into the dev-dependencies.
The crypto-* features are removed from edhoc-rs; testing depends on
edhoc-crypto being pulled in in parallel to the test, and a feature
selected on that.
Follow-up-for: openwsn-berkeley#127
chrysn
force-pushed
the
more-crypto-trait
branch
from
37cbdb6 to
f30d2d8
Compare
|
As git dev-dependencies are ignored by crates.io, I think that with this PR we can start #98 (publication to crates.io) over in earnest: edhoc-ead*, edhoc-consts, edhoc-crypto-trait and edhoc-rs could go to crates.io; the rest will stay unpublished for the moment. [edit: not quite -- edhoc-ead-zeroconf also depends on edhoc-crypto ... but that can be fixed] |
chrysn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we've only used crypto traits (#127) in the low-level objects, doing the hard-to-hacspec parts. This now applies the same to the high-level objects.
It still doesn't succeed in getting the dependency on all-the-implementations out, but at least now it's just a dev-dependency (depended on by the tests), and not a full dependency any more.
Examples moved to directly using the default edhoc-crypto selection, which makes it still easy to test around; actual applications I'd expect to depend on edhoc-crypto-something directly.