Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diag response, doc updates, platform command, -py2.6 #96

Merged
merged 15 commits into from
Jul 27, 2017
Merged

Diag response, doc updates, platform command, -py2.6 #96

merged 15 commits into from
Jul 27, 2017

Conversation

emarsman
Copy link
Member

No description provided.

rwoberholzer and others added 15 commits August 30, 2016 10:46
@rwoberholzer
Diagnostic requests now only show relevant response
e7bcd4e
@rwoberholzer
Added device platform command
a1b08ba
@peplin
Drop support for Python 2.6, pin version of pyserial.
a84ceb7 
pyserial no longer supports Python 2.6 (perhaps unintentionally - it is
using Python 2.7+ style string formatting as of v3.1.1). In the
interesting of looking to the future, we will use this opportunity to
drop support for Python 2.6.

Fixes #79.
@rwoberholzer
Merge pull request #83 from openxc/79-bye-bye-python2.6
922018b 
Drop support for Python 2.6, pin version of pyserial.
@rwoberholzer
Merge branch 'next' into diagnosticResponseCleanup
d1b8399
@rwoberholzer
Merge branch 'next' into devicePlatformCommand
fbcc0e8
@rwoberholzer
Merge pull request #86 from openxc/diagnosticResponseCleanup
b37e78a 
Diagnostic response cleanup
@rwoberholzer
Merge branch 'next' into devicePlatformCommand
3edcb07
@rwoberholzer
Merge pull request #85 from openxc/devicePlatformCommand
9fe5d93 
Device platform command
Updated command documentation to the current version
a68382c 
* Corrected --message-id command to --message

* Correct references of --network command to --network-host

* Added a openxc-generate-firmware-code header and description

* Updated to 2017 copyright date

* Added openxc-control platform command

*Clarified descriptions for the above commands
@emarsman
fix #91 by making file open w instead of wa
2d83c37
@emarsman
Merge pull request #93 from openxc/dump-wa
780ff1a 
fix #91 by making file open w instead of wa
@emarsman
changelog.rst for current next state (#94)
4ab03aa
@emarsman
Update version in README
d6f9edc
@emarsman
Merge pull request #95 from openxc/emarsman-patch-1
5ce6d59 
Update version in README
@emarsman emarsman changed the title Next Diag response, doc updates, platform command, -py2.6 Jul 21, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 59.147% when pulling 5ce6d59 on next into 7b22cac on master.

@kylewludwig
Copy link

Does the platform command work on your machines?
screen shot 2017-07-21 at 10 07 32 am

And the version command is also having issues for me sometimes
screen shot 2017-07-21 at 10 10 17 am

@emarsman
Copy link
Member Author

emarsman commented Jul 21, 2017 •
edited
Loading

#89 and #90 are the issues you're having. Not specific to these changes. Does platform work if you add --format json like the error message says? I didn't test this, but I did when it was originally committed.

Also, for platform, you'll need firmware newer than 7.2.0 i.e. current master.

@emarsman emarsman merged commit 28e7cb0 into master Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwoberholzer rwoberholzer rwoberholzer approved these changes

@kylewludwig kylewludwig Awaiting requested review from kylewludwig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emarsman @coveralls @kylewludwig @rwoberholzer @peplin