#sdy add sdy::NamedComputationOp in/out shardings and make it adhere to ShardableDataFlowOpInterface, and add op result data flow op interface methods.
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…e to `ShardableDataFlowOpInterface`, and add op result data flow op interface methods. This means Shardy can now add/sink dataflow edges to and propagate through `sdy::NamedComputation` ops. The added methods match the equivalent `ShardableDataFlowOpInterface` on block arguments. This makes the interface more complete, polishes up the utility functions, but will also be important when we make `ManualComputationOp` adhere to the `ShardableDataFlowOpInterface` as it will be overriding these new methods (it needs to set/get the shardings from the registered `out_shardings` op argument. PiperOrigin-RevId: 679155557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#sdy add
sdy::NamedComputationOpin/out shardings and make it adhere toShardableDataFlowOpInterface, and add op result data flow op interface methods.This means Shardy can now add/sink dataflow edges to and propagate through
sdy::NamedComputationops.The added methods match the equivalent
ShardableDataFlowOpInterfaceon block arguments. This makes the interface more complete, polishes up the utility functions, but will also be important when we makeManualComputationOpadhere to theShardableDataFlowOpInterfaceas it will be overriding these new methods (it needs to set/get the shardings from the registeredout_shardingsop argument.