Fixed compilation on Windows. #31
Conversation
|
I see that all PRs in this repository are from copybara and so I'm not sure this is the right place to open this PR. cc @ZixuanJiang @tomnatan30 (tagging you just based on activity on other PRs). |
|
Hey Anthony, thanks for sending the PR! We have just open sourced Shardy and we aren't accepting contributions yet, there are a few things we need to set up before that. Happy to fix this for you until we start accepting external PRs, if that's ok with you. |
|
That sounds good to me! Thanks @tomnatan30! I guess that explains all the PRs being from copybara. :) Would you mind letting me know once it's fixed so I can put up a PR in the XLA repository updating the dependency? Thanks! |
|
np! I'm updating the dep here: openxla/xla#15502 (via copybara) |
|
Great, thank you! :) |
I'm currently attempting to get XLA to compile on Windows with CUDA support and this PR fixes one of the issues I ran into related to the shardy dependency. The tl;dr is that designated initializers are a C++ 20 feature that GCC supports even when you're compiling using C++ 17 (which XLA does), but unfortunately MSVC is stricter and does not support it for that version of C++. This PR removes the uses of that feature from shardy.