Skip to content

Commit

Permalink
[cmake] Remove dependence on LLVM 'Core' component in the CMake build
Browse files Browse the repository at this point in the history
This change removes two spurious 'LINK_COMPONENTS Core' declarations in
the CMake build. Depending on the 'Core' component indicates that the
libraries depend on the code under 'llvm-project/llvm/lib/IR' (e.g. 'LLVMCore'
library), which is not true for the StablehloLinalgTransforms and
StablehloTOSATransforms libraries.
  • Loading branch information
christopherbate committed Sep 3, 2024
1 parent d68ab07 commit 00e8114
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions stablehlo/conversions/linalg/transforms/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ add_mlir_library(StablehloLinalgTransforms
StablehloOpsIncGen
StablehloLinalgTransformsPassIncGen

LINK_COMPONENTS
Core

LINK_LIBS PUBLIC
ChloOps
StablehloBase
Expand Down
3 changes: 0 additions & 3 deletions stablehlo/conversions/tosa/transforms/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ add_mlir_library(StablehloTOSATransforms
StablehloTOSAPDLLPatternsIncGen
StablehloOpsIncGen

LINK_COMPONENTS
Core

LINK_LIBS PUBLIC
MLIRIR
MLIRPass
Expand Down

0 comments on commit 00e8114

Please sign in to comment.