Address feedback

openxla · Jun 22, 2023 · c74c66b · c74c66b
1 parent 4b01419
commit c74c66b
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 22 deletions.
diff --git a/stablehlo/dialect/StablehloBytecode.cpp b/stablehlo/dialect/StablehloBytecode.cpp
@@ -65,7 +65,7 @@ namespace stablehlo_encoding {
 enum AttributeCode {
   // TO ADD ATTRIBUTE: Add an enum value with doc string for new attr.
 
-  ///   ArgResultAliasAttr(deprecated)
+  ///   ArgResultAliasAttr (obsolete)
   // kArgResultAliasAttr = 0,
 
   ///   ChannelHandleAttr {

diff --git a/stablehlo/dialect/StablehloOps.cpp b/stablehlo/dialect/StablehloOps.cpp
@@ -3280,16 +3280,5 @@ Operation* StablehloDialect::materializeConstant(OpBuilder& builder,
   return builder.create<ConstantOp>(loc, type, elementsAttr);
 }
 
-LogicalResult StablehloDialect::verifyRegionArgAttribute(
-    Operation* op, unsigned /*regionIndex*/, unsigned argIndex,
-    NamedAttribute attr) {
-  return success();
-}
-
-LogicalResult StablehloDialect::verifyOperationAttribute(Operation* op,
-                                                         NamedAttribute attr) {
-  return success();
-}
-
 }  // namespace stablehlo
 }  // namespace mlir
diff --git a/stablehlo/dialect/StablehloOps.h b/stablehlo/dialect/StablehloOps.h
@@ -59,16 +59,6 @@ class StablehloDialect : public Dialect {
   Operation *materializeConstant(OpBuilder &builder, Attribute value, Type type,
                                  Location loc) override;
 
-  // Registered hook to verify region arg attributes on operations.
-  LogicalResult verifyRegionArgAttribute(mlir::Operation *op,
-                                         unsigned regionIndex,
-                                         unsigned argIndex,
-                                         mlir::NamedAttribute attr) override;
-
-  // Registered hook to verify an attribute from this dialect on operations.
-  LogicalResult verifyOperationAttribute(mlir::Operation *op,
-                                         mlir::NamedAttribute attr) override;
-
   // Parses a type registered to this dialect.
   Type parseType(DialectAsmParser &parser) const override;