Fix the bitness of addition/subtraction in quantize op #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganchien
approved these changes
Apr 18, 2024
sdasgup3
force-pushed
the
specify-bitness
branch
from
d9e4bbb
to
2e04854
Compare
doyeonkim0
approved these changes
Apr 30, 2024
paulinesho
approved these changes
Apr 30, 2024
GleasonK
requested changes
Apr 30, 2024
sdasgup3
force-pushed
the
specify-bitness
branch
from
2e04854
to
f6fe066
Compare
GleasonK
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1627
Requesting the following for review:
@loganchien
@paulinesho
@doyeonkim0