Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve forward incompatibility error messaging #2569

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

GleasonK
Copy link
Member

@GleasonK GleasonK commented Oct 1, 2024

Now failure to --deserialize a portable artifact will include:

  1. The op that failed.
  2. The version that the portable artifact was serialized for.
  3. The current version of StableHLO.

This should help debugging compat issues at a glance.

Added a forward incompatible hypothetical feature vhlo.constant_v99, serialized for StableHLO_v2.0.0, which emulates a current version of StableHLO trying to parse a future operation that doesn't currently exist.

$ stablehlo-translate --deserialize file.mlirbc
unregistered operation 'vhlo.constant_v99' found in dialect ('vhlo') that does not allow unknown operations
note: in bytecode version 6 produced by: StableHLO_v2.0.0
failed to deserialize portable artifact using StableHLO_v1.7.5

@GleasonK GleasonK merged commit c6c1583 into openxla:main Oct 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants