[RFC] Add result accuracy to unary ops #2592
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposal to add result_accuracy to the following transcendental unary ops: `exp`, `expm1`, `log`, `logp1`, `logistic` and `tanh`.
[RFC] Add result accuracy to transcendental unary ops
GleasonK
reviewed
Oct 16, 2024
sdasgup3
reviewed
Oct 21, 2024
add description of the modes.
sdasgup3
approved these changes
Oct 21, 2024
hanrach9
changed the title
changm
reviewed
Oct 24, 2024
make explicit of compile time error
add more ops
|
|
Replying to @dimvar,
Yes.
We have higher accuracy software versions of these functions when the hardware accuracy isn't good enough, and we want to enable the accurate versions from Jax. Also it's been difficult for Jax users to reconcile inconsistent numerical behaviors when they depend on these functions across devices. This lets you express your requirements to the compiler in a device-independent fashion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add
result_accuracyattribute to the following transcendental unary ops to StableHLO:sin,cos,tan,tanh,sqrt,rsqrt,cbrt,exp,expm1,log,logp1,logisticanderf. Any feedback would be appreciated, thanks!