Skip to content

Commit

Permalink
Propagating frontend attributes from call operation to the callee wit…
Browse files Browse the repository at this point in the history
…h respect to the fusion attributes.

PiperOrigin-RevId: 631852761
  • Loading branch information
Google-ML-Automation committed Oct 2, 2024
1 parent 93be085 commit 3eb86be
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 1 deletion.
1 change: 1 addition & 0 deletions xla/service/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -1218,6 +1218,7 @@ cc_library(
":hlo_domain_isolator",
"//xla:status_macros",
"//xla:util",
"//xla:xla_data_proto_cc",
"//xla/hlo/ir:hlo",
"//xla/hlo/pass:hlo_pass",
"@com_google_absl//absl/container:flat_hash_map",
Expand Down
26 changes: 25 additions & 1 deletion xla/service/call_inliner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ limitations under the License.
#include "xla/service/call_inliner.h"

#include <memory>
#include <string>
#include <utility>
#include <vector>

Expand All @@ -34,6 +35,7 @@ limitations under the License.
#include "xla/service/hlo_domain_isolator.h"
#include "xla/status_macros.h"
#include "xla/util.h"
#include "xla/xla_data.pb.h"
#include "tsl/platform/errors.h"
#include "tsl/platform/statusor.h"

Expand Down Expand Up @@ -152,6 +154,29 @@ CallInliner::Inline(HloInstruction* call) {
const auto& callees = call->called_computations();
TF_RET_CHECK(callees.size() == 1);
HloComputation* callee = callees[0];

// Propagate the frontend attributes related to fusion from the call to the
// inlined instructions.
if (call->has_frontend_attributes()) {
const FrontendAttributes& call_attributes = call->frontend_attributes();
std::string has_fuse =
call_attributes.map().contains("MUST_FUSE") ? "MUST_FUSE"
: call_attributes.map().contains("MAXIMAL_FUSE") ? "MAXIMAL_FUSE"
: "";
if (!has_fuse.empty()) {
for (auto instruction : callee->instructions()) {
// Do so for only fusible instructions.
if (instruction->IsFusible()) {
FrontendAttributes frontend_attributes =
instruction->frontend_attributes();
frontend_attributes.mutable_map()->insert(
{has_fuse, call_attributes.map().at(has_fuse)});
instruction->set_frontend_attributes(frontend_attributes);
}
}
}
}

// We visit the callee, cloning its body into its caller.
SubcomputationInsertionVisitor visitor(call);
TF_RETURN_IF_ERROR(callee->Accept(&visitor));
Expand All @@ -160,7 +185,6 @@ CallInliner::Inline(HloInstruction* call) {

bool CallInliner::IsInlineableCallOp(HloInstruction* instruction) const {
return instruction->opcode() == HloOpcode::kCall &&
!instruction->has_backend_config() &&
!instruction->parent()->IsAsyncComputation();
}

Expand Down

0 comments on commit 3eb86be

Please sign in to comment.