PR #17112: Clean up for legacy comment and misleading error message.

Imported from GitHub PR #17112 Clean up for legacy comment since triton fp8 gemm is in place. Also clean up misleading error message in cublasLT runtime. Copybara import of the project: -- ef22252 by Elfie Guo <[email protected]>: Clean up for legacy comment and weird error message. Merging this change closes #17112 COPYBARA_INTEGRATE_REVIEW=#17112 from elfiegg:clean ef22252 PiperOrigin-RevId: 675089813
openxla · Sep 16, 2024 · 95d39d7 · 95d39d7
1 parent 98c6ee5
commit 95d39d7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/xla/debug_options_flags.cc b/xla/debug_options_flags.cc
@@ -110,8 +110,6 @@ DebugOptions DefaultDebugOptionsIgnoringFlags() {
 
   opts.set_xla_gpu_enable_cudnn_frontend(true);
 
-  // Note: CublasLt will be used for FP8 GEMMs regardless of the value of this
-  // flag.
   opts.set_xla_gpu_enable_cublaslt(false);
 
   opts.add_xla_gpu_enable_command_buffer(DebugOptions::FUSION);

diff --git a/xla/stream_executor/cuda/cuda_blas_lt.cc b/xla/stream_executor/cuda/cuda_blas_lt.cc
@@ -319,11 +319,11 @@ auto BlasLt::GetMatmulPlan(const gpu::GemmConfig& cfg,
 
   if (xla::primitive_util::IsF8Type(lhs_layout.dtype) &&
       lhs_layout.order == gpu::MatrixLayout::Order::kColumnMajor) {
-    return xla::Internal("The F8 LHS must be column-major");
+    return xla::Internal("The F8 LHS must be row-major");
   }
   if (xla::primitive_util::IsF8Type(rhs_layout.dtype) &&
       rhs_layout.order == gpu::MatrixLayout::Order::kRowMajor) {
-    return xla::Internal("The F8 RHS must be row-major");
+    return xla::Internal("The F8 RHS must be column-major");
   }
 
   TF_ASSIGN_OR_RETURN(auto output_dtype,