Skip to content

Commit

Permalink
[PJRT] Update stale comments.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 676206948
  • Loading branch information
cezheng authored and Google-ML-Automation committed Sep 19, 2024
1 parent 6f06258 commit e4ee0fe
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions xla/pjrt/pjrt_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -675,12 +675,18 @@ class PjRtClient {
// buffers' definition events will automatically become ready, unblocking
// downstream consumers of the buffers.
//
// A single call to CreateBuffersForAsyncHostToDevice creates a "batch" of
// buffers that share a single definition event, which may amortize some
// performance overheads, but means that none of the buffers are available to
// downstream consumers until all the transfers have completed. Multiple calls
// to CreateBuffersForAsyncHostToDevice should be made if it is desirable for
// buffers to become available as soon as transfers into them complete.
// Depending on the backend's implementation, a single call to
// CreateBuffersForAsyncHostToDevice may either:
// - Create a "batch" of buffers that share a single definition event, which
// may amortize some performance overheads, but means that none of the
// buffers are available to downstream consumers until all the transfers
// have completed, in which case multiple calls to
// CreateBuffersForAsyncHostToDevice should be made if it is desirable for
// buffers to become available as soon as transfers into them complete.
//
// - Create a "batch" of buffers with multiple underlying definitions
// events, and individual buffers become available to downstream consumers
// as soon as transfers into them complete.

// Helper class to all clients to asynchronously transfer data into buffers
// that are created uninitialized, see comments immediately above.
Expand Down

0 comments on commit e4ee0fe

Please sign in to comment.