presubmits: Add a presubmit for CHECK and related macros. #11217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_621892845
branch
2 times, most recently
from
bfe0ff0
to
e66032a
Compare
Generally it's a better idea to find a way to report the error rather than to crash the process. When XLA is used in a server, crashes expose the server to potential queries of death when unexpected data or API calls occur. Removing existing crashes is a longer-term fixit-type effort, but at least we can prevent new intentional crashes from slipping in. PiperOrigin-RevId: 621952801
copybara-service
bot
force-pushed
the
test_621892845
branch
from
e66032a
to
3d6326c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
presubmits: Add a presubmit for CHECK and related macros.
Generally it's a better idea to find a way to report the error rather than to
crash the process. When XLA is used in a server, crashes expose the server to
potential queries of death when unexpected data or API calls occur.
Removing existing crashes is a longer-term fixit-type effort, but at least we
can prevent new intentional crashes from slipping in.