Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XLA][HloDCE] Removal of unused outputs of fusions to consider multiple users of the same shape index (aka output) #17217

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Sep 16, 2024

[XLA][HloDCE] Removal of unused outputs of fusions to consider multiple users of the same shape index (aka output)

Changes:

  • Replaces check of users vs number of outputs with checking if number of unique outputs used is smaller than number of outputs
  • Before this change, if same shape index (aka same output) is used multiple times, we might not end up removing any of the unused.
  • Before this change, if an output has multiple users, and it is the only one used, we might not remove all the unused fusion outputs (aka will leave around outputs).

@copybara-service copybara-service bot force-pushed the test_674450072 branch 9 times, most recently from 101cbf4 to e7c8dd4 Compare September 17, 2024 23:11
…le users of the same shape index (aka output)

Changes:
* Replaces check of users vs number of outputs with checking if number of unique outputs used is smaller than number of outputs
* Before this change, if same shape index (aka same output) is used multiple times, we might not end up removing any of the unused.
* Before this change, if an output has multiple users, and it is the only one used, we might not remove all the unused fusion outputs (aka will leave around <number of users> outputs).
PiperOrigin-RevId: 675754198
@copybara-service copybara-service bot merged commit 2b1c609 into main Sep 17, 2024
@copybara-service copybara-service bot deleted the test_674450072 branch September 17, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant