Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory space related copies should not be normalized. #17218

Merged
merged 1 commit into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions xla/service/host_offload_utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -244,5 +244,17 @@ bool IsHostAsyncStart(const HloInstruction* instruction) {
instruction->async_execution_thread() == HloInstruction::kHostThread;
}

bool IsSynchronousCopyFromOrToHost(const HloInstruction* instruction) {
if (instruction->opcode() != HloOpcode::kCopy) {
return false;
}
return (instruction->shape().has_layout() &&
instruction->shape().layout().memory_space() ==
Layout::kHostMemorySpace) ||
(instruction->operand(0)->shape().has_layout() &&
instruction->operand(0)->shape().layout().memory_space() ==
Layout::kHostMemorySpace);
}

} // namespace host_offload_utils
} // namespace xla
3 changes: 3 additions & 0 deletions xla/service/host_offload_utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ bool IsValidDuringPureMemoryOffload(const HloInstruction* instruction);
// Returns true if the instruction is an async-start with host thread.
bool IsHostAsyncStart(const HloInstruction* instruction);

// Returns true if the copy is from or to host memory space.
bool IsSynchronousCopyFromOrToHost(const HloInstruction* instruction);

} // namespace host_offload_utils
} // namespace xla

Expand Down
Loading