Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XLA:SPMD] Fix scatter index-parallel partitioning issues. #17243

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Sep 17, 2024

[XLA:SPMD] Fix scatter index-parallel partitioning issues.

  1. Fix gather/scatter partitioning where operand/updates sharding should be aligned with indices' sharding in index-parallel case.
  2. Remove the assumption that gather/scatter index-parallel dim detection returns sorted dims where the dimension correspondence information is lost.

@copybara-service copybara-service bot changed the title [XLA:SPMD] Fix scatter index-parallel partitioning where operand/updates sharding should be aligned with indices' sharding. [XLA:SPMD] Fix scatter index-parallel partitioning issues. Sep 17, 2024
1. Fix gather/scatter partitioning where operand/updates sharding should be aligned with indices' sharding in index-parallel case.
2. Remove the assumption that gather/scatter index-parallel dim detection returns sorted dims where the dimension correspondence information is lost.

PiperOrigin-RevId: 675678391
@copybara-service copybara-service bot merged commit f6b6175 into main Sep 17, 2024
@copybara-service copybara-service bot deleted the test_675439880 branch September 17, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant