Fix ptx_compilation_test failure on H100 #17245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_675475325
branch
3 times, most recently
from
89c9d9c
to
25462ea
Compare
Unfortunately the test is still not as robust as I would like it to be. Some slightly differently generated PTX from Triton leads to some of the comparisons fails. In particular when comparing PTX compiled in one-go with PTX first compiled to a relocatable object and then linked into a binary. The solution for now is to not compare relocatable PTX compilation against non-relocatable PTX compilation. I'm also disabling autotuning as a precaution - even though it was not the cause of this issue. PiperOrigin-RevId: 675490844
copybara-service
bot
force-pushed
the
test_675475325
branch
from
25462ea
to
ccdd3c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ptx_compilation_test failure on H100
Unfortunately the test is still not as robust as I would like it to be.
Some slightly differently generated PTX from Triton leads to some of the comparisons fails.
In particular when comparing PTX compiled in one-go with PTX first compiled to a relocatable
object and then linked into a binary.
The solution for now is to not compare relocatable PTX compilation against non-relocatable
PTX compilation. I'm also disabling autotuning as a precaution - even though it was not the
cause of this issue.