Adding Strictness level to PGLE accuracy checker. #17259
+92
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shraiysh
force-pushed
the
pgle_strictness_levels
branch
from
f8b0e72
to
a414eb8
Compare
There was a problem hiding this comment.
Thanks for the PR!
Have we established the plan on how this is supposed to integrate with JAX? For one, I don't think this is how auto PGLE does the integration.
https://github.com/google/jax/pull/20475/files
https://github.com/openxla/xla/pull/11024/files
|
How about just using a string for the flag xla_gpu_pgle_accuracy_checker that can take values {'OFF' , 'WARN', 'ERROR'} |
shraiysh
force-pushed
the
pgle_strictness_levels
branch
from
a414eb8
to
abbf544
Compare
xla_gpu_pgle_accuracy_checker can take the values {OFF, WARN, ERROR}
and this flag decides what will be done when there are missing
instructions in PGLE profile: either do nothing (OFF), warn about it
(WARN) or halt compilation (ERROR)
|
Yes, enum also sounds good to me. I would also assume this would resemble what will be in JAX a little bit closer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values for the new flag:
xla_gpu_pgle_accuracy_checker: {OFF, WARN, ERROR}