Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constructor to MockSharding that also takes device list to allow tests that need working call to Sharding::devices(). #17268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Add constructor to MockSharding that also takes device list to allow tests that need working call to Sharding::devices(). #17268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions xla/python/ifrt/mock.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,12 @@ class MockSharding : public llvm::RTTIExtends<MockSharding, Sharding> {
BasicDeviceList::Create({}), MemoryKind(),
/*is_fully_replicated=*/false) {}

explicit MockSharding(tsl::RCReference<DeviceList> devices,
MemoryKind memory_kind = MemoryKind(),
bool is_fully_replicated = false)
: llvm::RTTIExtends<MockSharding, Sharding>(devices, memory_kind,
is_fully_replicated) {}

MOCK_METHOD(
(absl::StatusOr<
std::vector<std::pair<Shape, std::shared_ptr<const Sharding>>>>),
Expand Down
Loading