Use switch case without default in LiteralToValue #17279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apivovarov
force-pushed
the
opt_execution_trace_utils_2
branch
from
54114c7
to
914db47
Compare
reedwm
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Thank you for the PR! However, I prefer the way you did this in #17170. It is nice having the compiler verify you covered all types, but it also has the issue where if new types are added, they have to be added to this switch statement. In general when adding a new type, you have to modify very many places (as you are doing in #16585), so we should try reducing the number of places where each type needs to be listed separately. So I'll close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommendation:
Missing switch cases are a compiler error, so having a switch without a default case is preferable when possible
Change:
in
xla/mlir/tools/mlir_replay/public/execution_trace_utils.cc :: LiteralToValue(Literal) -> InterpreterValueThis PR removes IsTuple(), IsToken(), IsArray(), IsF8Type() and refactors the code to use single switch case block.