Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PJRT] Update stale comments. #17288

Merged
merged 1 commit into from
Sep 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions xla/pjrt/pjrt_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -675,12 +675,18 @@ class PjRtClient {
// buffers' definition events will automatically become ready, unblocking
// downstream consumers of the buffers.
//
// A single call to CreateBuffersForAsyncHostToDevice creates a "batch" of
// buffers that share a single definition event, which may amortize some
// performance overheads, but means that none of the buffers are available to
// downstream consumers until all the transfers have completed. Multiple calls
// to CreateBuffersForAsyncHostToDevice should be made if it is desirable for
// buffers to become available as soon as transfers into them complete.
// Depending on the backend's implementation, a single call to
// CreateBuffersForAsyncHostToDevice may either:
// - Create a "batch" of buffers that share a single definition event, which
// may amortize some performance overheads, but means that none of the
// buffers are available to downstream consumers until all the transfers
// have completed, in which case multiple calls to
// CreateBuffersForAsyncHostToDevice should be made if it is desirable for
// buffers to become available as soon as transfers into them complete.
//
// - Create a "batch" of buffers with multiple underlying definitions
// events, and individual buffers become available to downstream consumers
// as soon as transfers into them complete.

// Helper class to all clients to asynchronously transfer data into buffers
// that are created uninitialized, see comments immediately above.
Expand Down
Loading