[ROCm] clang support #17295
Closed
[ROCm] clang support #17295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @xla-rotation could you have a look, please! thanks! |
ddunl
reviewed
Oct 2, 2024
|
@ddunl lets hold off upstreaming this, we need some testing to do. I will ping you once it is done. |
|
@ddunl can you review/ merge now please. I have very few new changes particularly in |
ddunl
approved these changes
Oct 3, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
Imported from GitHub PR #17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f3164 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17295 from ROCm:ci_rv_clang b0f3164 PiperOrigin-RevId: 682045857
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 3, 2024
Imported from GitHub PR openxla/xla#17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f316408f62052125973cfff6f9371a91e84464 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 682045857
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Oct 4, 2024
Imported from GitHub PR openxla/xla#17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f316408f62052125973cfff6f9371a91e84464 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 682444804
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Imported from GitHub PR #17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f3164 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17295 from ROCm:ci_rv_clang b0f3164 PiperOrigin-RevId: 682444804
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Imported from GitHub PR #17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f3164 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17295 from ROCm:ci_rv_clang b0f3164 PiperOrigin-RevId: 682444804
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 4, 2024
Imported from GitHub PR openxla/xla#17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f316408f62052125973cfff6f9371a91e84464 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 682444804
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Imported from GitHub PR #17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f3164 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17295 from ROCm:ci_rv_clang b0f3164 PiperOrigin-RevId: 682444804
|
Made a couple extra changes to fix configure_test on ARM, should merge later today or Monday. Sorry for the delay! |
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 4, 2024
Imported from GitHub PR openxla/xla#17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f316408f62052125973cfff6f9371a91e84464 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 682444804
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Oct 4, 2024
Imported from GitHub PR openxla/xla#17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f316408f62052125973cfff6f9371a91e84464 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 682444804
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Imported from GitHub PR #17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f3164 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17295 from ROCm:ci_rv_clang b0f3164 PiperOrigin-RevId: 682444804
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 4, 2024
Imported from GitHub PR openxla/xla#17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f316408f62052125973cfff6f9371a91e84464 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 Reverts 0927f90 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 682444804
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Oct 7, 2024
Imported from GitHub PR openxla/xla#17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f316408f62052125973cfff6f9371a91e84464 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 682444804
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
Imported from GitHub PR #17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f3164 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17295 from ROCm:ci_rv_clang b0f3164 PiperOrigin-RevId: 682444804
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 7, 2024
Imported from GitHub PR openxla/xla#17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f316408f62052125973cfff6f9371a91e84464 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 682444804
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Oct 7, 2024
Imported from GitHub PR openxla/xla#17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f316408f62052125973cfff6f9371a91e84464 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 PiperOrigin-RevId: 683234976
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 7, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 683241935
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 7, 2024
This change: - Makes GpuTimer a template that gets instantiated as CudaTimer and RocmTimer. - Moves the required GpuDriver functions into CudaDriver and RocmDriver - Adjusts RocmExecutor and CudaExecutor accordingly FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 683198192
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 7, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 681625188
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 7, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 683252345
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 7, 2024
Imported from GitHub PR openxla/xla#17295 Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm. @draganmladjenovic @i-chaochen Copybara import of the project: -- b0f316408f62052125973cfff6f9371a91e84464 by Ruturaj4 <[email protected]>: [ROCm] clang support Merging this change closes #17295 PiperOrigin-RevId: 683234976
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 7, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 682462156
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 7, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17295 from ROCm:ci_rv_clang b0f316408f62052125973cfff6f9371a91e84464 PiperOrigin-RevId: 683251587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings up clang support for ROCm XLA. This is required to implement clang support for JAX+XLA for ROCm.
@draganmladjenovic @i-chaochen