PR #17430: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client #17803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_680653976
branch
3 times, most recently
from
3f355b3
to
aa23d2d
Compare
Imported from GitHub PR #17430 On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Copybara import of the project: -- 80eb830 by Harsha HS <[email protected]>: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Merging this change closes #17430 COPYBARA_INTEGRATE_REVIEW=#17430 from ROCm:ci_use_shared_ptr_20240920 80eb830 PiperOrigin-RevId: 681556381
copybara-service
bot
force-pushed
the
test_680653976
branch
from
aa23d2d
to
91587de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #17430: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client
Imported from GitHub PR #17430
On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same
Copybara import of the project:
--
80eb830 by Harsha HS [email protected]:
[ROCm] Use unique_ptr for TupleHandle in pjrt_se_client
On older gcc (specifically in Ubuntu-20.04) and absl copy operator
fails to copy created TupleHandle into an existing variable.
Instead use unique_ptr to accompalish the same
Merging this change closes #17430
FUTURE_COPYBARA_INTEGRATE_REVIEW=#17430 from ROCm:ci_use_shared_ptr_20240920 80eb830