PR #17858: [ROCm] Fix build brake caused by missing dso_loader.h includes #17876
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_681479175
branch
2 times, most recently
from
86abbb4
to
101e5f7
Compare
|
I think this is now unnecessary -- I fixed it another way in #17869 |
…udes Imported from GitHub PR #17858 The issue was introduced here -> b30b420#diff-923ec2612240244a60ae28c17f798a7daeccbab84a8e9de9efd7ba96c311c763L115 Some of the ROCm files need `dso_loader.h`. Copybara import of the project: -- 3853105 by Milica Makevic <[email protected]>: Return dso_loader.h includes for ROCm Merging this change closes #17858 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17858 from ROCm:ci_hotfix_241002 3853105 PiperOrigin-RevId: 681479175
copybara-service
bot
force-pushed
the
test_681479175
branch
from
101e5f7
to
8437c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #17858: [ROCm] Fix build brake caused by missing dso_loader.h includes
Imported from GitHub PR #17858
The issue was introduced here -> b30b420#diff-923ec2612240244a60ae28c17f798a7daeccbab84a8e9de9efd7ba96c311c763L115
Some of the ROCm files need
dso_loader.h.Copybara import of the project:
--
3853105 by Milica Makevic [email protected]:
Return dso_loader.h includes for ROCm
Merging this change closes #17858
FUTURE_COPYBARA_INTEGRATE_REVIEW=#17858 from ROCm:ci_hotfix_241002 3853105