Add missing check that iteration variable has scalar shape. #19334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
So far, the WhileLoopFusibleSinking pass assumed that the loop iteration variable returned by the call to GetLoopInductionVarTupleIdx() has a scalar shape. But with a recent change, this method also detects more complex patterns for loop induction variables, which can include non-scalar shapes. Add an extra check so that the assumption in the pass is not broken. PiperOrigin-RevId: 696421547
|
Closing this in favor of instead ensuring that the assumption holds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing check that iteration variable has scalar shape.
So far, the WhileLoopFusibleSinking pass assumed that the loop iteration
variable returned by the call to GetLoopInductionVarTupleIdx() has a scalar
shape. But with a recent change, this method also detects more complex patterns
for loop induction variables, which can include non-scalar shapes. Add an extra
check so that the assumption in the pass is not broken.