PR #16775: Add test for EmitReducePrecisionIR #19381
Merged
+199
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_696730664
branch
2 times, most recently
from
36ebf45
to
7a15369
Compare
Imported from GitHub PR #16775 I noticed that the `EmitReducePrecisionIR` function from `xla/service/elemental_ir_emitter.h` is not covered by unit tests. Given its non-trivial logic, I believe it should be thoroughly tested, particularly for corner cases. Changes in this PR: - Declare `EmitReducePrecisionIR` function in `xla/service/elemental_ir_emitter.h` - Add `EmitReducePrecisionIR_F16ToF8e5m2` test - Add `EmitReducePrecisionIR_F16ToF8e4m3fn` test Related PR: - [PR-16585](#16585) Add support for float8_e4m3 Copybara import of the project: -- 5972205 by Alexander Pivovarov <[email protected]>: Add test for EmitReducePrecisionIR Merging this change closes #16775 COPYBARA_INTEGRATE_REVIEW=#16775 from apivovarov:elemental_ir_emitter_test 5972205 PiperOrigin-RevId: 696792994
copybara-service
bot
force-pushed
the
test_696730664
branch
from
7a15369
to
521cd7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #16775: Add test for EmitReducePrecisionIR
Imported from GitHub PR #16775
I noticed that the
EmitReducePrecisionIRfunction fromxla/service/elemental_ir_emitter.his not covered by unit tests.Given its non-trivial logic, I believe it should be thoroughly tested, particularly for corner cases.
Changes in this PR:
EmitReducePrecisionIRfunction inxla/service/elemental_ir_emitter.hEmitReducePrecisionIR_F16ToF8e5m2testEmitReducePrecisionIR_F16ToF8e4m3fntestRelated PR:
Copybara import of the project:
--
5972205 by Alexander Pivovarov [email protected]:
Add test for EmitReducePrecisionIR
Merging this change closes #16775
FUTURE_COPYBARA_INTEGRATE_REVIEW=#16775 from apivovarov:elemental_ir_emitter_test 5972205