Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upkeep][XLA-Code-Health] Resolve 2 instances of the following issue: Todo (resolved) #19514

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −2
Open

[Upkeep][XLA-Code-Health] Resolve 2 instances of the following issue: Todo (resolved) #19514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions xla/hlo/evaluator/hlo_evaluator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3804,7 +3804,6 @@ absl::StatusOr<Literal> StochasticConvertOp(const Literal& operand_literal,
primitive_type_constant>(
operand_literal, random_literal, result_shape);
}
// TODO(b/232442915): Enable converting big floats to small floats.
return Unimplemented(
"Stochastically converting from type %s to type %s is not "
"implemented.",
Expand All @@ -3826,7 +3825,7 @@ absl::StatusOr<Literal> StochasticConvertOp(const Literal& operand_literal,
primitive_util::UnsignedIntegralTypeForBitWidth(
primitive_util::BitWidth(primitive_type_constant))>(
operand_literal, random_literal, result_shape);
} // TODO(b/232442915): Enable converting big floats to small floats.
}
return Unimplemented(
"Stochastically converting from type %s to type %s is not "
"implemented.",
Expand Down
Loading