Remove S3 upload concurrency

[benoit74]

Fix #2118

Changes:

• revert increase of sockets from Increase S3 socket limit to 250 #2093, this was not needed in the past, and I don't expect this to be needed if we do not push too many concurrent requests (which we shouldn't)
• await upload of image to S3: while not awaiting the upload could help save some crawling time, it cannot be efficiently handled without proper queue size management (otherwise we end-up with current situation where too many uploads are queued at once). Implementing proper queue management is not worth it

Nota: we might want to open an issue to support async S3 upload with proper queue management on the medium/long term. I'm not convinced at all this is worth to implement, most (all?) Python scrapers work pretty well without it and I do not expect much benefit (i.e. price to pay is too high)

[kelson42]

@benoit74 Thank you very much for the PR. I will let @audiodude full judge this PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.25%. Comparing base (b66f1a9) to head (ea3db9b).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2120      +/-   ##
==========================================
- Coverage   75.26%   75.25%   -0.01%     
==========================================
  Files          41       41              
  Lines        3198     3197       -1     
  Branches      706      706              
==========================================
- Hits         2407     2406       -1     
  Misses        674      674              
  Partials      117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kelson42]

@audiodude Can you please review this PR?

[kelson42]

LGTM

[audiodude]

LGTM