Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure AWS SDK has access to object size when issuing an upload #2145

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

benoit74
Copy link
Contributor

Fix #2117

data is a buffer in our usage of the S3 class, and SDK prefer buffer to streams when it comes to PubObject command, so let's simplify things.

Tested locally with forced upload to S3 (by manipulating the If-None-Match value passed to upstream get). Before the change, I have the usual warnings, after the change they are gone.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.29%. Comparing base (fc2af69) to head (150734e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
- Coverage   75.33%   75.29%   -0.04%     
==========================================
  Files          41       41              
  Lines        3207     3202       -5     
  Branches      706      706              
==========================================
- Hits         2416     2411       -5     
  Misses        674      674              
  Partials      117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review January 28, 2025 13:45
@benoit74 benoit74 requested a review from kelson42 January 28, 2025 13:46
@benoit74 benoit74 self-assigned this Jan 28, 2025
@kelson42 kelson42 merged commit efbe8a2 into main Jan 28, 2025
6 checks passed
@kelson42 kelson42 deleted the fix_s3_warnings branch January 28, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure AWS sdk has access to object size when issuing the PutObject
2 participants